support-python-private-classifier#4075
support-python-private-classifier#4075VarshaUN wants to merge 11 commits intoaboutcode-org:developfrom
Conversation
VarshaUN
force-pushed
the
support-python-private-package
branch
2 times, most recently
from
ef81e8a to
f2c2b35
Compare
Signed-off-by: Varsha U N <varshamaddur2006@gmail.com> Signed-off-by: Varsha U N <varshamaddur2006@gmail.com> Signed-off-by: Varsha U N <varshamaddur2006@gmail.com>
VarshaUN
force-pushed
the
support-python-private-package
branch
from
f2c2b35 to
e03db23
Compare
Signed-off-by: Varsha U N <varshaun58@gmail.com>
Signed-off-by: Varsha U N <varshaun58@gmail.com>
There was a problem hiding this comment.
@VarshaUN Thanks++ for the PR, this is looking great.
See comments for some small improvements and we can merge after that.
Apologies for the late review. 😅
Signed-off-by: Varsha U N <varshaun58@gmail.com>
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks++ @VarshaUN!
A couple more related changes are required as private classifiers are used generally in other python package manifests too, not just pyproject.toml files, so please see my comments.
Signed-off-by: Varsha U N <varshaun58@gmail.com>
|
Hey @AyanSinhaMahapatra I have moved that two lines of code into a function in utils.py and imported it in pypi.py and used it in handlers as you have mentioned. |
There was a problem hiding this comment.
@VarshaUN thanks++ for the updates to support all cases where this is seen, looking good. Could you add tests to cover all the cases, and this should be ready to merge.
Also please make sure all tests pass, and verify that the test expectation changes are intended and related to this PR: https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=16089&view=logs&j=1412dbfa-421a-5a40-8ddf-7073fc46aa19&t=13c90161-2109-5957-f563-a96fefc7d869
Signed-off-by: Varsha U N <varshaun58@gmail.com>
…arshaUN/scancode-toolkit into support-python-private-package
Signed-off-by: Varsha U N <varshaun58@gmail.com>
| def is_simple_path_pattern(path): | ||
| return path.endswith('*') and path.count('*') == 1 | ||
|
|
||
| def is_private_package(classifiers): |
There was a problem hiding this comment.
This should not be in utils, but in the pypi.py
Signed-off-by: Varsha U N <varshaun58@gmail.com>
3 participants
Fixes #3968
Tasks
Run tests locally to check for errors.
Signed-off-by : Varsha U N varshaun58@gmail.com